Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: element remove leak #55

Merged
merged 4 commits into from
Sep 19, 2024
Merged

fix: element remove leak #55

merged 4 commits into from
Sep 19, 2024

Conversation

zhourengui
Copy link
Contributor

@zhourengui zhourengui commented Sep 16, 2024 •
edited by coderabbitai bot
Loading

Description

清理掉remove状态的元素 否则元素并不会被释放造成了内存泄漏的情况

Visuals

修改前的dom节点：
image

修改后的dom节点：
修改后元素始终保持一个数值内 之前并没有清理掉remove状态的元素
image

Checklist

  • My code follows the style guidelines and recommended practices of this project
  • I have performed a self-review of my own code and fixed the problems I found
  • I have tested my change that my fix is effective or that my feature works, and that it does not break existing functionality.

Any TODOs?

A summary of any remaining work required to complete the requirements of the task.

Summary by CodeRabbit

Summary by CodeRabbit

  • 新功能
    • 优化了过滤逻辑，提高了性能和可理解性，简化了处理状态为移除的实体的方式。
    • 改进了状态管理，确保在移除所有键时正确触发回调。

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
motion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 5:04am

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 16, 2024 •
edited
Loading

Walkthrough

此次更改简化了 src/CSSMotionList.tsx 中 genCSSMotionList 函数的过滤逻辑。更新后的逻辑直接过滤掉状态为 STATUS_REMOVE 的实体，省去了对先前实体的查找和相关条件检查。同时，removeKey 函数的实现也进行了重构，确保状态更新基于最新的状态，并在所有键被移除时触发 onAllRemoved 回调，从而增强了组件的功能。

Changes

文件 更改摘要
src/CSSMotionList.tsx 简化了 genCSSMotionList 函数的过滤逻辑，直接过滤状态为 STATUS_REMOVE 的实体，并重构了 removeKey 函数以改进状态管理和控制流。

Poem

在草地上我欢跳，
过滤逻辑变简单，
实体移除不再烦，
兔子乐在其中欢。
跳跃间，代码更清晰，
轻松写出新篇章！ 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zhourengui zhourengui mentioned this pull request Sep 16, 2024
Closed
zombieJ
zombieJ reviewed Sep 18, 2024
View reviewed changes
src/CSSMotionList.tsx Outdated Show resolved Hide resolved
@zhourengui zhourengui requested a review from zombieJ September 18, 2024 15:55
@zombieJ
Copy link
Member

zombieJ commented Sep 19, 2024

我修了一下 lint，merge 一下 master~

@afc163 afc163 changed the title fix：element remove leak fix: element remove leak Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (4da2b5f) to head (ad49dde).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   98.45%   98.46%   +0.01%     
==========================================
  Files          12       12              
  Lines         388      392       +4     
  Branches      109      109              
==========================================
+ Hits          382      386       +4     
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 072d50d into react-component:master Sep 19, 2024
9 checks passed
@zombieJ
Copy link
Member

zombieJ commented Sep 19, 2024

+ rc-motion@2.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees

@zombieJ zombieJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhourengui @zombieJ @afc163